search

jfmengels / elm-review-documentation

Provides elm-review rules to help with the quality and correctness of your Elm project's documentation
https://package.elm-lang.org/packages/jfmengels/elm-review-documentation/latest/
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

Make test script cross-platform #9

Closed fredericbonnet closed 4 years ago

fredericbonnet commented 4 years ago

This pull request fixes issue #8 using npm-run-all as suggested. It uses the -s flag for sequential execution of test:* subscripts. npm-run-all will run all matching NPM scripts in the order they are defined in package.json, so it should run in the same order as the original script.

I have also added the -l flag that prefixes each script output with the script name for easier troubleshooting. npm test will stop at the first subscript failure. npm test -- -c will run all the subscripts regardless of their completion status.

Happy Hacktoberfest!

fredericbonnet commented 4 years ago

Yeah I screwed up the submission date for Hacktoberfest. I genuinely thought the PR had to be accepted between Oct 1-30, but actually that's the submission date that counts :)

If you don't mind, you can close/reject this PR and I'll submit a new one tomorrow with your proposed changes.

jfmengels commented 4 years ago

Yeah I screwed up the submission date for Hacktoberfest. I genuinely thought the PR had to be accepted between Oct 1-30, but actually that's the submission date that counts :)

Oh I misunderstood this too! But it does make sense :smile:

If you don't mind, you can close/reject this PR and I'll submit a new one tomorrow with your proposed changes.

I don't mind, let's do that :+1: