Closed lue-bird closed 1 year ago
For patterns like
case ModuleNameLookupTable.moduleNameAt lookupTable range of
Just [ "Basics" ] ->
Do you prefer leaving them as is or changing them to an uncons pattern
case ModuleNameLookupTable.moduleNameAt lookupTable range of
Just ("Basics" :: []) ->
I tend to prefer [ "Basics" ] ->
(even with multiple elements [ "A", "B", "C" ] ->
) when I know the exact number. So yes, leave them as is
I will add
elm/random
simplifications next, but first a bit of cleanup. If you don't like certain changes, let's discuss and use one style consistently.Node
access calls and prefer desctructuringkeepOnlyFix
andparenthesizeFix
instead where possiblenoopFix
with more explicit alternatives (toIndetityFix
orkeepOnlyFix
)sequence
into-- LIST HELPERS
)firstThatReportsError
to avoid deep_ ->
nesting and decouple sub-rulesneighboringMap
,withBeforeMap
List.partition (always False)
fullyAppliedPrefixOperatorChecks
expressionVisitorHelp
::
pattern to list elements[ , ]
pattern