search

jfmengels / elm-review-simplify

Provides elm-review rules to simplify your Elm code
https://package.elm-lang.org/packages/jfmengels/elm-review-simplify/latest/
BSD 3-Clause "New" or "Revised" License
20 stars 9 forks source link

elm-review-simplify should never remove elm/json #238

Closed miniBill closed 9 months ago

miniBill commented 9 months ago

The Elm compiler gets really unhappy if elm/json is removed, and it's hard-ish to fix

lue-bird commented 9 months ago

Maybe you wanted to open this issue in elm-review-unused? simplify doesn't remove dependencies.

jfmengels commented 9 months ago

Agreed. Also, can you please add (in the new issue) some information as to why elm/json should stay?

miniBill commented 9 months ago

Oh, yeah, wrong project, thanks

miniBill commented 9 months ago

Should I reopen https://github.com/jfmengels/elm-review-unused/issues/30 or open a new issue?

jfmengels commented 9 months ago

I think that one was a false positive, so please open a different issue.