I'll apologize in advance for the first commit which one could say does multiple things at once. Sorry!
Introduce property elements.get which can detect known elements, including information of whether some parts are unknown
allowed introducing generic checks for e.g. member
onCollectionWithAbsorbingCheck now also reports e.g. List.all identity (a :: False :: bs), callOnListWithAbsorbingElement therefore became unnecessary
Indexable was confusing. Does literalElements refer to the "fromList" construction method? I would expect no but some checks were relying on that behavior.
→ remove in favor of fromList.getList and elements.get
FromListProperties contained unionLeftElementsStayOnTheLeft. To me it does not seem like the right place. First, not every type that can be constructed from a list has a union function. Second, a type can have different union functions, e.g. Array.append, the pipe-friendly version prependTo and the pipe-friendly prepend function appendTo.
leftElementsStayOnTheLeft is now provided as an argument to the union checks
Simplify FromListProperties to match any fromList call, not just on literals
Refactor -DetermineSize functions
Introduce separate declarations for the grouped properties of a type
(Unrelated note: I've added my personal todo list for simplify publically in https://github.com/lue-bird/elm-review-simplify/issues/1 which always contains all the refactorings I plan to do in the near future but have not yet formalized)
jfmengels
commented
12 months ago
I'll apologize in advance for the first commit which one could say does multiple things at once. Sorry!
elements.getwhich can detect known elements, including information of whether some parts are unknownonCollectionWithAbsorbingChecknow also reports e.g.List.all identity (a :: False :: bs),callOnListWithAbsorbingElementtherefore became unnecessaryIndexablewas confusing. DoesliteralElementsrefer to the "fromList" construction method? I would expect no but some checks were relying on that behavior.fromList.getListandelements.getFromListPropertiescontainedunionLeftElementsStayOnTheLeft. To me it does not seem like the right place. First, not every type that can be constructed from a list has a union function. Second, a type can have different union functions, e.g.Array.append, the pipe-friendly versionprependToand the pipe-friendly prepend functionappendTo.leftElementsStayOnTheLeftis now provided as an argument to the union checksFromListPropertiesto match anyfromListcall, not just on literals-DetermineSizefunctions(Unrelated note: I've added my personal todo list for simplify publically in https://github.com/lue-bird/elm-review-simplify/issues/1 which always contains all the refactorings I plan to do in the near future but have not yet formalized)