search

jfmengels / elm-review-simplify

Provides elm-review rules to simplify your Elm code
https://package.elm-lang.org/packages/jfmengels/elm-review-simplify/latest/
BSD 3-Clause "New" or "Revised" License
20 stars 9 forks source link

Add access record type alias constructor call simplification #269

Closed lue-bird closed 9 months ago

lue-bird commented 9 months ago

Part of https://github.com/jfmengels/elm-review-simplify/issues/162

(Record first second).first --> first

with record type aliases defined in the current module, project or a dependency.

Something really strange I've noticed: The changes from https://github.com/jfmengels/elm-review-simplify/pull/206 and https://github.com/jfmengels/elm-review-simplify/pull/210/ seem to be completely lost (maybe even more?). Maybe these we're force-overwritten or something (https://github.com/jfmengels/elm-review-simplify/pull/207 especially seems sus). At any rate, I'll try to re-apply these changes in the next PR.

jfmengels commented 9 months ago

Thanks, this is a nice change :blush:

I'll look into recovering the lost PRs, I imagine that that's my fault :see_no_evil: