Combined call and composition checks

jfmengels / elm-review-simplify

Provides elm-review rules to simplify your Elm code

BSD 3-Clause "New" or "Revised" License

19 stars 9 forks source link

Closed lue-bird closed 11 months ago

lue-bird commented 11 months ago

Refactor based on the idea in #246

Convert all checks into combined "IntoFnCheck"s
Introduce module-level IntoFnCheck declarations for each fn
Go through each "use together / in combination with ... / for the same thing as a ... check" and convert to a IntoFnCheck

Your idea works really well in making checks simpler and more reliable. Props for coming up with it!

jfmengels commented 11 months ago

If rebasing means I'll have to reopen a new PR, so be it. This PR is mostly to track progress for me but more transparently.

You're good to go :+1: :wink:

And I'm fine with you making multiple branches/PRs at the same time, even if they were to conflict (we can always solve them, no worries).

lue-bird commented 11 months ago

That should be it. Comment if you notice more checks where we could combine composition+call or if some edge case should be tested.