Closed lue-bird closed 1 year ago
I hope existing code doesn't break since we now use Rule.withContextFromImportedModules
(I don't think it changes the way the rule is run here but you know best).
I hope existing code doesn't break since we now use Rule.withContextFromImportedModules (I don't think it changes the way the rule is run here but you know best).
It won't in this case. That can only change the ProjectContext
given to fromProjectToModule
, where the previous context's fields were ignored anyway.
I'll merge this now, we can tackle the other comments later. Great work @lue-bird :heart:
Implementing a lookup that helps figure out the module-local qualification for things https://github.com/jfmengels/elm-review-simplify/pull/82#discussion_r1096590841
module
importsType(..)
Just
,Nothing
,Err
,Ok
,True
,False
). If you find other ones, let me know!Overall, this is great because you can be sure that fixes (like those of #82) will always produce valid code. (well except when a module has a member with the same name as an implicitly imported thing)