Fix comment visitor order

jfmengels / elm-review

Analyzes Elm projects, to help find mistakes before your users find them.

https://package.elm-lang.org/packages/jfmengels/elm-review/latest/

Other

255 stars 13 forks source link

Fix comment visitor order #112

Closed SiriusStarr closed 2 years ago

SiriusStarr commented 2 years ago

Add test for withCommentsVisitor to test which comments are included and verify they are in source order.
Fix comment visitor to visit in source order.
Update documentation for withCommentsVisitor and withSimpleCommentsVisitor to note that they do not visit doc comments for functions, types, and type aliases.

jfmengels commented 2 years ago

Very nice improvements! I'll be touching it a tiny bit (and solving the docs.json conflict). I'll close the PR because it's a bit hard to push changes to the branch myself, but your commits will make it in :)