search

jfmengels / elm-review

Analyzes Elm projects, to help find mistakes before your users find them.
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
Other
252 stars 13 forks source link

Fix ModuleNameLookupTable resolving to indirect dependencies #135

Closed jfmengels closed 2 years ago

jfmengels commented 2 years ago

Fixes #134

This makes sure that the module name lookup table doesn't look at modules from indirect dependencies.

@hanshenrik could you try the fix out? You can do that by cloning this repo, checking out this branch (issue-134) and then running the following command:

LOCAL_ELM_REVIEW_SRC=<path-to-elm-review>/src elm-review --config <path-to-elm-review>/review --rules NoUnused.Variables --ignore-dirs "lib"

Don't forget to replace the paths. And you might get some errors for things that you've ignored.

hanshenrik commented 2 years ago

Yes, this seems to work! Thanks a lot!

jfmengels commented 2 years ago

Thank you for checking!

I just released this fix in v2.9.0 of this package. You should only have to bump this package in your review/elm.json.

Please keep the issues you run into coming! And if you happen to enjoy and find value in the tool, maybe you could talk Folq into sponsoring the project? :heart: