search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

CI keeps failing #118

Closed jfmengels closed 5 months ago

jfmengels commented 1 year ago

THe CI keeps failing, even though the tests pass locally. This reduces my trust in the CI, and may at some point cause me to ship a version with broken code...

hingew commented 5 months ago

I just ran into the same issue. I tested the tests locally with multiple different node versions:

Version Result
14.17.6 :x:
16.20.2 :x:
18.20.3 :x:
20.14.0 :heavy_check_mark:
22.3.0 :x:

I guess the snapshots for the tests where recorded with the node version 20.x but in the CI we use the version 16.x. The node version 16.x and 20.x gives diffrent outputs for JSON.parse(...) errors.

A possible solution for this would be to enforce a node version for devleopment. This could be archived with one of the following options

jfmengels commented 5 months ago

Fixed by #157