search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Replace fs-extra #120

Closed jfmengels closed 2 weeks ago

jfmengels commented 1 year ago

In https://github.com/jfmengels/node-elm-review/pull/119 we replaced most usages of fs-extra. We kept it because of the copy capabilities that it has that are not in fs or graceful-fs.

(Note: it's fine to keep it in new-package/maintenance/update-examples-from-preview.js, that's a separate generated project for packages)

lydell commented 8 months ago

According to https://nodejs.org/api/fs.html#fscopyfilesyncsrc-dest-mode, fs.copyFileSync has existed since Node.js 8.5.0, so after a quick search it looks like all that needs to be done is to change fsExtra.copyFileSync into fs.copyFileSync and then remove fs-extra.

lishaduck commented 4 weeks ago

Yay, cpSync is stable as of 22.3