search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Add types to promisify-port.js #127

Closed marc136 closed 1 year ago

marc136 commented 1 year ago

This PR is a step towards https://github.com/jfmengels/node-elm-review/issues/125, and adds types to lib/promisify-port.js.

I was not sure about the descriptive comments, feel free to change them however you see fit.

I never wrote jsdoc comments to such an extent before, adding a .d.ts file would have been easier for me. Thank you for the challenge :laughing:

marc136 commented 1 year ago

I realized later, that adding .d.ts definition files is also possible. So I extracted the hardly readable JSDoc types to types/promisify-port.d.ts.