search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 25 forks source link

Add types to `app-wrapper.js` #155

Closed lishaduck closed 2 weeks ago

lishaduck commented 2 weeks ago

I'm unsure as what type flags is supposed to be, beyond that it's not Flags. I'm pretty sure VSCode was wrong that it's Options.

Relates to: #125

lishaduck commented 2 weeks ago

Oh, I see. This is blocked on #126. I'll try to see if I fix it sometime.

lishaduck commented 2 weeks ago

Ok, the failures from #126 were a bit intimidating, so I figure I'll just port them over here and just coauthor them.

lishaduck commented 2 weeks ago

I plan on relanding this as separate PRs later this week.

jfmengels commented 2 weeks ago

Sounds good, take your time @lishaduck and thank you for looking into this!

jfmengels commented 2 weeks ago

I'm unsure as what type flags is supposed to be, beyond that it's not Flags. I'm pretty sure VSCode was wrong that it's Options.

Flags is something that looks very much like Options. If I'm not mistaken, it's an object that is passed to the worker_threads that takes a number of fields (with some differences) taken from Options.

lishaduck commented 1 week ago

Yikes! I'm up to 178 commits on my branch. I really need to split them up 😬