jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Nodejs version enforcement for development #157

Closed hingew closed 5 months ago

hingew commented 5 months ago

Issues: #133 #118

Development node version

This PR will suggest to use the node version 16 for development. This can be archived with asdf or nvm (see #118 for details).

Runtime node version

The minimum runtime version, determined through ls-engines, is >=14.17. This PR also adds the use of ls-engines, as suggested from @jfmengels (#133). With this PR the ls-engines runs in the CI to make sure that we match the engines we have specified in the package.json.

socket-security[bot] commented 5 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/ls-engines@0.9.2 Transitive: environment, eval, filesystem, network, shell, unsafe +320 16.4 MB

🚮 Removed packages: npm/elm-doc-preview@5.0.5, npm/elm-review@2.11.2, npm/glob@9.3.5

View full report↗︎

socket-security[bot] commented 5 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Potential typo squat npm/array.prototype.some@1.1.6

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/array.prototype.some@1.1.6
jfmengels commented 5 months ago

@SocketSecurity ignore npm/array.prototype.some@1.1.6

jfmengels commented 5 months ago

Thank you very much @hingew :tada: I hope sticking to v16 won't be a problem for most people. Otherwise, we can always choose a newer version later.

The only thing we should add is add some guarantees that we don't use features from Node.js that are not available in v14.

lishaduck commented 5 months ago

The only thing we should add is add some guarantees that we don't use features from Node.js that are not available in v14.

I'm bumping devdeps right now, and eslint-plugin-n supports this, which you already use.