jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 25 forks source link

JSDoc Updates #165

Closed lishaduck closed 1 week ago

lishaduck commented 1 week ago

Sort, format, lint jsdocs.

Depends on #164

Here's the diff as GH doesn't play well with stacks from forks: https://github.com/lishaduck/node-elm-review/compare/turbo...jsdocs

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/folder-hash@4.0.4 None 0 7.09 kB types
npm/@types/jest@27.5.2 Transitive: environment, eval +12 447 kB types
npm/@types/minimist@1.2.5 None 0 6.27 kB types
npm/@types/node@14.18.63 None 0 1.61 MB types
npm/@typescript-eslint/eslint-plugin@5.62.0 Transitive: environment, filesystem +42 6.99 MB jameshenry
npm/@typescript-eslint/parser@5.62.0 Transitive: environment, filesystem +30 2.14 MB jameshenry
npm/elm-test@0.19.1-revision12 Transitive: environment, filesystem, shell +8 489 kB lydell
npm/elm-tooling@1.15.1 environment, filesystem, network, shell 0 100 kB lydell
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-config-turbo@2.0.4 Transitive: environment, eval, filesystem, shell +2 477 kB turbobot
npm/eslint-plugin-unicorn@52.0.0 Transitive: environment, eval, filesystem, unsafe +71 10.9 MB sindresorhus
npm/eslint@8.57.0 environment, filesystem Transitive: eval, unsafe +75 11.1 MB eslintbot

🚮 Removed packages: npm/@types/chalk@2.2.0, npm/@types/jest@29.5.1, npm/@types/minimist@1.2.2, npm/@types/node@18.15.13, npm/@typescript-eslint/eslint-plugin@5.59.1, npm/@typescript-eslint/parser@5.59.1, npm/elm-test@0.19.1-revision10, npm/elm-tooling@1.15.0, npm/eslint-config-prettier@8.8.0, npm/eslint-plugin-unicorn@46.0.0, npm/eslint@8.39.0, npm/strip-ansi@6.0.1

View full report↗︎

jfmengels commented 1 week ago

Thanks again :relaxed: There was a TS error that was introduced here but I pushed a fix.

lishaduck commented 1 week ago

Thanks again ☺️ There was a TS error that was introduced here but I pushed a fix.

Thanks! I did a bunch of rebasing and must've missed one.

jfmengels commented 1 week ago

Yeah, I later noticed you fixed the issue in the typings PR. That's fine, no worries :+1: