search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Maintenance TODO List #169

Open lishaduck opened 3 months ago

lishaduck commented 3 months ago

I plan on getting to all of these someday, but, as this is a rather long list, I don't mind if anyone wants to do some.

Now

Once I'm back from hiatus, I'll get around to fixing some review feedback and stuff.

Soon

Relatively soon

Someday

Complete

jfmengels commented 3 months ago

These all sound good to me.

I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but I may not be up to date.

Maybe let's create separate issues for most of these? At least the ones marked as relatively doon and later?

lishaduck commented 3 months ago

I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but I may not be up to date.

I was thinking of elm-review as an application (it's not a library, so 🤷‍♂️).

Maybe let's create separate issues for most of these? At least the ones marked as relatively doon and later?

👍

jfmengels commented 3 months ago

I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but I may not be up to date.

I was thinking of elm-review as an application (it's not a library, so 🤷‍♂️).

Right, but unless we ship a single binary, the dependencies enforced by our shrinkwrap will likely not be the ones that a user downloads when they download elm-review, since our shrinkwrap will not be evaluated. The shrinkwrap in the repo would only be used for development purposes.

lishaduck commented 3 months ago

I don't know if we want a shrinkwrap though. Back in the days that was only recommended for applications. I haven't heard of that advice changing but I may not be up to date.

I was thinking of elm-review as an application (it's not a library, so 🤷‍♂️).

Right, but unless we ship a single binary, the dependencies enforced by our shrinkwrap will likely not be the ones that a user downloads when they download elm-review, since our shrinkwrap will not be evaluated. The shrinkwrap in the repo would only be used for development purposes.

Oh, is that how it works? Thanks for explaining :)

lishaduck commented 2 months ago

Oh, just a small FYI: I've been focusing on some other OSS work recently, and I've just about finished it; however I've been working on my school Mac, but I'll have to return it soon, after which I'll be an old, slow Windows machine. Therefore, I'll probably stop helping out until mid-August. I'll still be around if you need to @mention me, but I probably won't be writing any new PRs (or rebasing old ones). Have a nice month! "See" you laterish.

jfmengels commented 2 months ago

@lishaduck That is absolutely fine. Thank you for the huge amount of work you put in the project, I highly appreciate it :heart: And you can come back whenever you want :smile:

lishaduck commented 2 months ago

That is absolutely fine.

Yeah, I just didn't want to seem like I was leaving a bunch of stuff unfinished, I'm just on a brief hiatus.

Thank you for the huge amount of work you put in the project, I highly appreciate it ❤️

Thanks. I, too, appreciate that.

Bye from a Windows box!

P.S.: If you need Windows testing in the next month or so, just ping me :)