search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

ESM #171

Open lishaduck opened 5 months ago

lishaduck commented 5 months ago

If elm-review moved to ESM, would you have problems? elm-review HEAD requires Node 14, so Node supports elm-review. We don't expose an API, so this wouldn't be breaking there. As a CLI, it makes no difference. I don't think anyone would care,[^1] but here's the issue.

On the elm-review side, this helps with TypeScript and exposing a public API (#170).

[^1]: Well, you might care philosophically, but ESM is the future, for better and for worse. If you hate ESM, that's perfectly fair. Nonetheless, that's not what this is about. This is "do you have code that this will break somehow" and eventually coordination.

lishaduck commented 5 months ago

This would require switching to Vitest, a more correct, prettier, and feature-complete test runner that competitively fast. Luckily, it's a drop-in replacement, so it should just be as easy as changing the imports and the configuration.