search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Help refactor #174

Closed lishaduck closed 5 months ago

lishaduck commented 5 months ago

Reland the remaining changes from #126.

Depends on #168. Here's the diff as GH doesn't play well with stacks from forks: https://github.com/lishaduck/node-elm-review/compare/eslints...help-refactor

socket-security[bot] commented 5 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/eslint-plugin-eslint-comments@4.3.0 None +2 97.9 kB eslint-community-bot
npm/@typescript-eslint/eslint-plugin@6.21.0 Transitive: environment, filesystem +40 7.24 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 Transitive: environment, filesystem +32 2.55 MB jameshenry
npm/eslint-plugin-n@16.6.2 filesystem Transitive: environment, unsafe +20 2.17 MB weiran.zsd
npm/eslint-plugin-promise@6.2.0 None 0 69.6 kB eslint-community-bot
npm/eslint-plugin-security@2.1.1 None +2 468 kB eslint-community-bot

🚮 Removed packages: npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/eslint-plugin-node@11.1.0

View full report↗︎

lishaduck commented 5 months ago

This works, it makes more sense logically, etc. However, it no longer lazily calls unknownCheck(). I'm starting to wonder how worthwhile this is after all.

lishaduck commented 5 months ago

Ok, I decided to approach this differently then #126 did. It doesn't always return true, it can also never return and exit instead. I've update the types to reflect this.

jfmengels commented 5 months ago

Thank you for your work on this @lishaduck!