search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Fix colors not showing up #220

Closed jfmengels closed 4 months ago

jfmengels commented 4 months ago

Colors were not showing up anymore when you running a plain elm-review. It seems it was broken in 69ac731 when turning the report into undefined, though I'm not entirely sure how that's related :thinking:

cc @lishaduck

lishaduck commented 4 months ago

It seems it was broken in 69ac731 when turning the report into undefined, though I'm not entirely sure how that's related 🤔

That commit link isn't right. Anyway, I think I recall some type conflicts, this should work as well. Not sure why that ts-expect-error isn't needed anymore 🤷‍♂️

lishaduck commented 4 months ago

That commit link isn't right.

0de6faae0d1dfe005574857099f4acdf456f5756, for reference.

Anyway, I think I recall some type conflicts, this should work as well. Not sure why that ts-expect-error isn't needed anymore 🤷‍♂️

I think this is correct, though I still don't really know why such an innocuous change made such a difference, especially given this project's code coverage. And I guess that that ts-expect-error was added in 0de6faae0d1dfe005574857099f4acdf456f5756, so I guess it makes sense, a bit?

lishaduck commented 4 months ago

Oh, and Prettier's also failing in CI :) That ternary can be moved onto the same line again.

jfmengels commented 4 months ago

That commit link isn't right.

My bad :facepalm: