jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Have the GitHub Actions run not fail when version has not been bumped #27

Closed jfmengels closed 3 years ago

jfmengels commented 3 years ago

When working on a package created using elm-review new-package, we get a GitHub Actions workflow, one for tests and one for publish, which publishes the package whenever the version has changed.

The problem is that we sometimes get false failures. https://github.com/jfmengels/elm-review-common/runs/1419530740?check_suite_focus=true

Scenario:

The version has not changed, so we should not attempt publishing. The problem is that before we even check whether we should do the publishing (which is done in elm-publish-action), we run some tests.

Ideally, we should do the same check as what is done in elm-publish-action. If there is a need to publish, continue with the remaining steps. Otherwise, abort the workflow but let the workflow pass (green check, instead of red check).

I don't know how best to solve this issue, as my understanding of GitHub Actions is too limited at the time.

jfmengels commented 3 years ago

Fixed. If you run into this, create a new package using new-package and copy the GitHub action from that package to your current one.