search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

CI improvements #288

Closed lishaduck closed 3 weeks ago

lishaduck commented 3 weeks ago

Endlessly chasing that 1min ci time...

jfmengels commented 3 weeks ago

Nice! Thank you!

Btw heads up, I delete all GitHub Actions cache, because some other PRs started failing for very odd reasons, so I'm suspecting that some PRs CI tests affect each other. I hope I'm wrong because that would suck. So the cache cleanup is not related to this PR, and you might get slower builds than expected if you were hoping to see them be real quick thanks to the cache.

lishaduck commented 3 weeks ago

Btw heads up, I delete all GitHub Actions cache, because some other PRs started failing for very odd reasons, so I'm suspecting that some PRs CI tests affect each other.

Hm. Cache pollution should only be possible if something snuck into main, so 🤷‍♂️ If CI failed on a branch, then you fixed it but I messed up a glob so turbo restored the cache, it might be possible. What PRs?

I hope I'm wrong because that would suck. So the cache cleanup is not related to this PR, and you might get slower builds than expected if you were hoping to see them be real quick thanks to the cache.

That was (mostly) a joke. Thanks for letting me know though.