search

jfnavarro / PrimeTV2

A tool to visualize reconciled trees
Other
1 stars 4 forks source link

Bug in computation of widest label #14

Closed arvestad closed 10 years ago

arvestad commented 12 years ago

In LayoutTrees::biggestLabel(), there are two loops; one for computing the widest species label, and one for computing the widest gene label. Unfotrunately, a copy-n-paste error has the gene label size read in both loops. When there are more species than genes this is fatal, and just unfortunate in other cases.

The fix is simple. Line 614 should be: Node *n = species->getNode(i);

However, for reasons I don't understand, this is connected to a drawing mistake (unless I am confusing the issues!). When I fixed this bug in my source tree, the root of the whole drawn reconciliation is chopped off. As an example, consider the case http://www.csc.kth.se/~arve/tmp/Bengts_gener/HBG286440_ccmMd.pdf

jfnavarro commented 12 years ago

I fixed the error and I dont see the problem you mention, could you please send me the tree files when that happens??

arvestad commented 12 years ago

Sure, data attached! And the result I get.

Lasse

Mar 12, 2012 kl. 9:06 PM skrev Jos Carlos Fernndez Navarro:

I fixed the error and I dont see the problem you mention, could you please send me the tree files when that happens??

Reply to this email directly or view it on GitHub: https://github.com/jfnavarro/PrimeTV2/issues/14#issuecomment-4460466

jfnavarro commented 11 years ago

I did not get the files in my email