jforman / binder

Django Web Admin Gui for manging BIND DNS Zones
129 stars 41 forks source link

Remove tests for checking DNS resolution #34

Closed Dunedan closed 9 years ago

Dunedan commented 9 years ago

The tests checking the DNS resolution aren't reliable as they rely on specific behavior of the DNS resolution on the local system. As they are not reliable it makes no sense to keep them as they currently are.

95b8643 tried to fix the case when either no internet connectivity is available or the IPs of the resolved host name have been changed, by resolving localhost instead. That introduced problems with different operating systems and network setups. 880eee0 tried to fix that, but as different local setups are possible such an approach will always only work for some environments. Therefore the only solution I currently see, is to remove the checks all together for now.

This pull request fixes the last failing test, which will allow proper checking if upcoming pull requests break functionality which is already covered by tests.