Closed jfowkes closed 1 year ago
@lindonroberts would you be able to do a quick review? Should be a very easy one!
@jfowkes - this looks good. Two very minor things to consider:
Thanks @lindonroberts, I have updated the path comments to read HOMEBREW_PREFIX/...
Regarding setting homebrew_path=None, did you mean setting homebrew_prefix=None? Since hombrew_path is a local variable within each darwin branch it can't cause an undefined variable error. On the other hand, homebrew_prefix has global scope when defined (only in the darwin branch) so this could easily cause undefined variable errors in future.
@jfowkes - yes, I meant to say homebrew_prefix
@lindonroberts great I've initialised homebrew_prefix to None, this is now ready for merge if you're happy?
The fallback paths on macOS should not be hardcoded with
/usr/local/
as this will break on the new ARM macs since they do not use/usr/local/
by default (c.f. #39).This PR switches to querying homebrew for its install location in the same way as #39 does in
install_scripts.py
(this still returns/usr/local/
on my Intel mac install).This also resolves #45