search

jfpedroza / neotest-elixir

Neotest adapter for Elixir
MIT License
38 stars 10 forks source link

Use ExUnit.CLIFormatter only when extra_formatters are not provided #2

Closed ajayvigneshk closed 1 year ago

ajayvigneshk commented 1 year ago

Hey 👋🏼! Thanks for the work on the elixir adapter.

I work on a project where we cannot use ExUnit.CLIFormatter due to certain issues. We use a custom formatter instead. I think it's more a sensible default to not include ExUnit.CLIFormatter when extra_formatters are provided (as one can add ExUnit.CLIFormatter as an extra formatter anyways)

jfpedroza commented 1 year ago

Interesting... Thanks for contributing.

Can you update the README to say something like:

      -- Other formatters to pass to the test command as the formatters are overridden
      -- Can be a function to return a dynamic value.
      -- Default: {"ExUnit.CLIFormatter"}
      extra_formatters = {"ExUnit.CLIFormatter", "ExUnitNotifier"},

To point that the CLI formatter is the default and needs to be added if you change the option.