jfqd / redmine_helpdesk

Lightweight helpdesk plugin for redmine.
MIT License
192 stars 102 forks source link

Don't autofill owner-email and copy-to #144

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hello, in the task that is created by email, fields owner-email and copy-to are empty, but in the description I see all email headers.

image

arnekaulfuss commented 4 years ago

Wich version of redmine are you using? Did you do all needed configuration as described here: https://github.com/jfqd/redmine_helpdesk#usage

ghost commented 4 years ago

Hello arnekaulfuss, thank you for your reply.

Redmine version 4.0.2.stable Ruby version 2.5.3-p105 (2018-10-18) [x86_64-linux] Rails version 5.2.2

I did all configuration that was needed. If I fill owner-email by myself it works fine.

ANemcov commented 4 years ago

Don't autofill too Environment: Redmine version 4.0.3.stable Ruby version 2.6.3-p62 (2019-04-16) [x86_64-linux] Rails version 5.2.2.1

ANemcov commented 4 years ago

In file mail_handler_patch.rb: at line 32 (need project, but ued issue:

# any cc handling needed?
custom_value = custom_field_value(issue.project, 'cc-handling')
if (!@email.cc.nil?) && (custom_value.value == '1')

at line 115 (in query params need issue.id, but was issue.project.id:

def custom_field_value(issue,name)
  custom_field = CustomField.find_by_name(name)
  CustomValue.where(
    "customized_id = ? AND custom_field_id = ?", issue.id, custom_field.id
  ).first
end
arnekaulfuss commented 4 years ago

it's one more: https://github.com/jfqd/redmine_helpdesk/pull/143

I asked just to be sure that it's not something different because my patch is not approved. For me its working in my project.

ghost commented 4 years ago

it's one more:

143

I asked just to be sure that it's not something different because my patch is not approved. For me its working in my project.

Thank you, it works!

jfqd commented 4 years ago

Was fixed today.