search

jfqd / redmine_helpdesk

Lightweight helpdesk plugin for redmine.
MIT License
192 stars 102 forks source link

Redmine version 4.1 Compatibility #150

Closed rohitthakral closed 4 years ago

rohitthakral commented 4 years ago

Hi Guys

Can I collaborate with someone to get this compatible with v4.1 of Redmine?

Thanks Rohit

rohitthakral commented 4 years ago

Ok. So I tested the latest version on Redmine 4.1 and here is the first issue:

MailHandler: an unexpected error occurred when receiving email: undefined method `id' for nil:NilClass

This comes up whenever a ticket is updated using email. The email is marked read and the ticket is not updated.

I got this when I configured the log to produce debug information.

rohitthakral commented 4 years ago

ok guys. Got this fixed.

Changed lib/mail_handler_patch.rb line 96 with this:

if issue.closed? && custom_value.present? && custom_value.value.present?

instead of

if issue.closed? && custom_value.value.present?