search

jfqd / redmine_helpdesk

Lightweight helpdesk plugin for redmine.
MIT License
192 stars 102 forks source link

Reopen closed issue doesn't work #156

Closed lmorillas closed 3 years ago

lmorillas commented 3 years ago 
Environment:
  Redmine version                4.1.1.stable
  Ruby version                   2.6.6-p146 (2020-03-31) [x86_64-linux]
  Rails version                  5.2.4.2
  Environment                    production
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.10.4
  Mercurial                      4.8.2
  Bazaar                         2.8.0
  Git                            2.20.1
  Filesystem                     
Redmine plugins:
  additionals                    2.0.24
  redmine_canned_responses       0.3.2
  redmine_helpdesk               0.0.18
  redmine_knowledgebase          4.1.1
  redmine_questions              1.0.2
  redmine_tags                   4.0.0

When an issue is closed, answering the email doesn't reopen it. The log raises it when receives the email :

E, [2020-09-17T15:21:12.464489 #1519] ERROR -- : MailHandler: an unexpected error occurred when receiving email: undefined methodvalue' for nil:NilClass `

lmorillas commented 3 years ago

Solved with #150 Patch https://github.com/jfqd/redmine_helpdesk/issues/150#issuecomment-605822801 if issue.closed? && custom_value.present? && custom_value.value.present?

at lib/mail_handler_patch.rb line 96