jfree / jfreechart

A 2D chart library for Java applications (JavaFX, Swing or server-side).
http://www.jfree.org/jfreechart/
GNU Lesser General Public License v2.1
1.22k stars 462 forks source link

Quarter constructor does not validate quarter and year parameter ranges. #400

Open El-Toham opened 6 months ago

El-Toham commented 6 months ago

Documentation: https://www.jfree.org/jfreechart/javadoc/org/jfree/data/time/Quarter.html#%3Cinit%3E(int,int) Version: 1.5.4 Tested by: JUnit


| 1) Test for the quarter parameter: |


@Test(expected = IllegalArgumentException.class) public void quarterShouldInRange(){ Quarter quarter = new Quarter(5, 2024); }


| 2) Test for the year parameter: |


@Test(expected = IllegalArgumentException.class) public void yearShouldInRange(){ Quarter quarter = new Quarter(1, 19999); }