jfree / jfreesvg

A fast, lightweight Java library for creating Scalable Vector Graphics (SVG) output.
http://www.jfree.org/jfreesvg
GNU General Public License v3.0
319 stars 58 forks source link

Missing semicolon in SVGGraphics2D#strokeStyle() #38

Closed christianAppl closed 3 years ago

christianAppl commented 3 years ago

A semicolon is missing for the miterLimit. I did not check, whether you already fixed this issue in the most recent version. Sorry for the inconvenience - simply close this issue in that case.

It should be:

if (Math.abs(DEFAULT_MITER_LIMIT - miterLimit) > 0.001) {
   b.append("stroke-miterlimit: ").append(geomDP(miterLimit)).append(";");
}

But it is:

if (Math.abs(DEFAULT_MITER_LIMIT - miterLimit) > 0.001) {
   b.append("stroke-miterlimit: ").append(geomDP(miterLimit));
}

Example: grafik grafik

Solution: grafik grafik

jfree commented 3 years ago

This is a duplicate of https://github.com/jfree/jfreesvg/issues/36 right? The fix is already committed for the next release.

christianAppl commented 3 years ago

It is not a duplicate of issue #36! That issue was about the miter limit not being applied at all, due to a logical error in the condition.

This ticket is about the missing semicolon for that parameter (.append(";")) - an issue I had not seen then. If said semicolon is already appended in the current version - everything is perfectly fine.

The missing semicolon is preventing the following parameter from being applied (as you can see in the screenshots).

(Due to the different timezone my responses can take some time.)

jfree commented 3 years ago

Oops, let me look again.

jfree commented 3 years ago

Fixed