jfroelich / rss-reader

A simple Chrome extension for viewing RSS feeds
Other
10 stars 0 forks source link

Fix testing of rewrite rules #775

Closed jfroelich closed 5 years ago

jfroelich commented 5 years ago

I've temporarily copied over the rules here for testing, but ideally this should import the rules from somewhere, or, define local rules and test against those exclusively. I should not even be testing the real rules, I should only be exercising the function behavior and asserting against its expected vs actual behavior

jfroelich commented 5 years ago

I am now testing the real rules. However, this issue is still not fixed, I need to be testing misc rules.

jfroelich commented 5 years ago

The issue is resolved. There is still the separate issue of improving the tests but that is for another day.