jfroelich / rss-reader

A simple Chrome extension for viewing RSS feeds
Other
10 stars 0 forks source link

The message broadcasted by update-feed should be more opaque #776

Closed jfroelich closed 5 years ago

jfroelich commented 5 years ago

Do not pass the entire giant feed object through the channel. Expose only those properties needed by event consumers. Also, pass those properties as properties of the event itself, not a nested feed object, because callers should only expect a basic event, not a full fledged feed object. Also, review why it is even needed. If the only things needed are things like the cleaned feed title, then maybe just expose title.