jfrog / JFrog-Cloud-Installers

Template to deploy Artifactory Enterprise cluster.
Apache License 2.0
78 stars 140 forks source link

[ansible/artifactory] Fixes #331 Install doesn't work with non-default user and group #332

Open Hiruma31 opened 1 year ago

Hiruma31 commented 1 year ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it: Artifactory, and probably all services, will fail to start when using a non-default value for $service_user and $service_group

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # GitHub #331

Special notes for your reviewer: I only worked on the artifactory part, but included the other components based on the documentation (they apparently don't use positional arguments like Artifactory's installer) XRay Insight Distribution

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Hiruma31 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

Hiruma31 commented 1 year ago

recheck

bbaassssiiee commented 12 months ago

I copied and signed this PR into https://github.com/jfrog/JFrog-Cloud-Installers/pull/351 which passes the checks.