jfrog / JFrog-Cloud-Installers

Template to deploy Artifactory Enterprise cluster.
Apache License 2.0
78 stars 140 forks source link

[ansible/artifactory] Assert that database username and password are defined. #336

Closed bbaassssiiee closed 1 year ago

bbaassssiiee commented 1 year ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it: The looping in the creation tasks for user, database and privileges in the postgres role did not fail on undefined values. Input validation was missing, and the logging of item=None is not so useful.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #311

Special notes for your reviewer:

Logeshwarsn commented 1 year ago

@bbaassssiiee Could you please address the comment ?