jfrog / JFrog-Cloud-Installers

Template to deploy Artifactory Enterprise cluster.
Apache License 2.0
78 stars 138 forks source link

[ansible/artifactory_nginx] Refactoring of the artifactory_nginx role #388

Closed EmptyByte closed 3 months ago

EmptyByte commented 3 months ago

…up is now optional.

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it: This PR makes the NGINX repositories setup optional. A user now needs to set the variable artifactory_nginx_setup_repos to true when they want to install/configure the NGINX official repositories. Otherwise, it does not. By default, NGINX is available in the RHEL repositories (refer to: Red Hat documentation ).

The main advantage is that we do not configure additional repositories unless requested, making it more idempotent and following user choices. Other enhancements include modularity changes and the use of distribution-based variables. This update also deprecates the artifactory_nginx_ssl role, as the new role will handle both situations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: Please review the changes related to the optional NGINX repository setup and the deprecation of the artifactory_nginx_ssl role. This role was not yet tested/linted and some minor correct might be required.

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


EmptyByte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

EmptyByte commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

EmptyByte commented 3 months ago

recheck

EmptyByte commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

EmptyByte commented 3 months ago

Will rework both nginx and postgresql.