jfrog / artifactory-gradle-plugin

JFrog Gradle plugin for Build Info extraction and Artifactory publishing.
Apache License 2.0
21 stars 15 forks source link

Upgrade to jackson-databind 2.17.0 #110

Open veita opened 6 months ago

veita commented 6 months ago

Fixes jfrog/artifactory-gradle-plugin#109


github-actions[bot] commented 6 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

veita commented 6 months ago

I have read the CLA Document and I hereby sign the CLA

veita commented 6 months ago

This issue causes https://github.com/jeremylong/DependencyCheck/issues/6542.

eyalbe4 commented 6 months ago

@veita, As the above failing tests show, this dependency upgrade causes some versions of Gradle versions to fail. We need to come up with an alternative solution, since merging this PR will most probably break many pipelines out there.

image
veita commented 6 months ago

Sure that the reason for the failure is Jackson version 2.17.0?

Unsupported class file major version 61 points to Java 17. And the class files in https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.17.0/jackson-databind-2.17.0.jar all have version 52.0 (Java 1.8).

eyalbe4 commented 6 months ago

I believe so @veita. Take a look at the screenshot I attached above. You'll see the jackson package name as part of the error message.

veita commented 6 months ago

I see Eyal and you're probably right. But I don't understand how the error could relate to Java class file major version 61 when the class files in jackson-databind-2.17.0.jar from Maven Central have version 52.0.

Could it be that the jackson-databind-2.17.0.jar in the test is not the original from Maven Central but something built with Java 17?

aikebah commented 6 months ago

@veita @eyalbe4 It's due to forward-incompatible behaviour of Gradle with respect to multi-release jars in its instrumentation attempts for plugins. See https://github.com/gradle/gradle/issues/27156 for all the detail.