search

jfrog / artifactory-gradle-plugin

JFrog Gradle plugin for Build Info extraction and Artifactory publishing.
Apache License 2.0
21 stars 15 forks source link

Replace deprecated use of convention with extension #62

Closed bmuschko closed 11 months ago

bmuschko commented 1 year ago

Fix for https://github.com/jfrog/artifactory-gradle-plugin/issues/43

I ran the unit tests with ./gradlew clean build -x test. I could not run functional tests against a local Artifactory instance. It seems like Artifactory OSS doesn't offer a darwin distribution anymore? I assume you are running those tests on CI anyway? Optimally, your functional tests should download Artifactory automatically and install it as a fixture for running functional tests. You could probably use Testcontainers for that purpose.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

bmuschko commented 1 year ago

recheck

yahavi commented 1 year ago

@bmuschko The tests are failing. Maybe give running the plugin on a local project a shot before making changes to this PR. Could you also sign the CLA as well? Thanks!

yahavi commented 11 months ago

Hi @bmuschko To speed up the resolution of this problem, we've opened https://github.com/jfrog/artifactory-gradle-plugin/pull/72, which eliminates the reliance on conventions. Please feel free to review it at your convenience.

bmuschko commented 11 months ago

Thanks for making the change. The main reason why I didn't pursue the PR was the CLA. I would have needed to understand it more deeply to feel comfortable with signing it.