Rename ArtifactoryPluginConvention to ArtifactoryPluginExtension

jfrog / artifactory-gradle-plugin

JFrog Gradle plugin for Build Info extraction and Artifactory publishing.

Apache License 2.0

20 stars 15 forks source link

Rename ArtifactoryPluginConvention to ArtifactoryPluginExtension #73

Open Goooler opened 9 months ago

Goooler commented 9 months ago

Better alignment with the migration of convention usages.

Follow up #72.

[x] All tests passed. If this feature is not already covered by the tests, I added new tests.

github-actions[bot] commented 9 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Goooler commented 9 months ago

I have read the CLA Document and I hereby sign the CLA

yahavi commented 9 months ago

Hey @Goooler and thanks for your contribution! The renaming here does create a breaking change for Kotlin users, and it's important to note that we didn't make this change with that intention in mind. Do you think there's a genuine reason to justify this modification?

Goooler commented 9 months ago

I believe we should follow the Gradle guidance to use a standard extension(including honoring the standard extension name), we can note this point in changelog and recommend users to use artifactory block to configure properties like the Groovy did.