Closed skulczycki closed 3 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
Hi @yahavi can you review this PR and approve CLA? It is a regression and we relay on this functionality. Thanks
@skulczycki Thanks for your contribution. We had a team conversation about it. We think that it is better to extract the VCS information the same way we do in the Jenkins Artifactory plugin, using Git.extractVcs(). The VCS information should be collected automatically for every build.
I create a PR that should add this functionality - https://github.com/jfrog/artifactory-maven-plugin/pull/23 We'd appreciate any feedback/review on this PR.
@skulczycki, We released Maven Artifactory plugin 3.3.0. In this version, the VCS information is populated automatically.
We'd appreciated your feedback on that.
Many thanks for that, I will try new version this week.
I have noticed that for some time now our projects are not uploading VCS revision information to Artifactory. For that I have raised the issue in "Build-Info" project https://github.com/jfrog/build-info/issues/544
However reviewing older version of Maven plugin I have noticed that this information was poplulated in Maven plugin not in the BuildInfo code.
What this change does it restores the functionality and uploads "vcs" information together with the BuildInfo as described here: https://www.jfrog.com/confluence/display/JFROG/Maven+Artifactory+Plugin