search

jfrog / artifactory-maven-plugin

A Maven plugin to resolve artifacts from Artifactory, deploy artifacts to Artifactory, capture and publish build info.
https://www.jfrog.com/confluence/display/JFROG/Maven+Artifactory+Plugin
Apache License 2.0
24 stars 26 forks source link

Support excluding build info module properties #56

Open dg424 opened 1 year ago

dg424 commented 1 year ago

Is your feature request related to a problem? Please describe.

Yes, please see question posted here - https://github.com/jfrog/artifactory-maven-plugin/issues/55 - related to fix here - https://github.com/jfrog/jenkins-artifactory-plugin/pull/720

Describe the solution you'd like to see

Please implement the fix from the Jenkins plugin into the maven plugin as well.

Describe alternatives you've considered

No response

Additional context

No response

rquinio1A commented 1 year ago

+1, there should be a big warning that build-info captures all Maven properties, thus sensitive data will leak if passed as a Maven property.

ddag commented 1 year ago

+1, there should be a big warning that build-info captures all Maven properties, thus sensitive data will leak if passed as a Maven property.

Yes, but why not just port same fox that's already in the Jenkins plug-in ? It's the same base code I believe, but the Jenkins code does not pass those along.