search

jfrog / artifactory-maven-plugin

A Maven plugin to resolve artifacts from Artifactory, deploy artifacts to Artifactory, capture and publish build info.
https://www.jfrog.com/confluence/display/JFROG/Maven+Artifactory+Plugin
Apache License 2.0
24 stars 26 forks source link

Ignores nonProxyHosts from settings.xml #65

Open TobiX opened 1 year ago

TobiX commented 1 year ago

Describe the bug

The proxy support merged with #64 and included in release 3.6.0 ignores the <nonProxyHosts> setting from settings.xml

Current behavior

Plugin does not consider proxy exceptions when connecting to Artifactory.

Reproduction steps

  1. Consider this settings in Maven's settings.xml:
    <proxy>
      <active>true</active>
      <protocol>http</protocol>
      <host>proxy.corp.bogus</host>
      <port>80</port>
      <nonProxyHosts>localhost*|127.0.0.1|*.corp.bogus</nonProxyHosts>
    </proxy>
  1. Try to reach an Artifactory server at artifactory.corp.bogus
  2. The plugin tries to connect to the Artifactory server through the proxy and fails

Expected behavior

Plugin should consider proxy exceptions when connecting to Artifactory.

Artifactory Maven plugin version

3.6.0

Operating system type and version

N/A

JFrog Artifactory version

No response

Maven version

3.9.1

lfvjimisola commented 1 year ago

We have the same issue with the plugin due to the fact that is does not handle nonProxyHosts in settings.xml in setupProxy.

jycr commented 2 months ago

any news about this issue?

FDegenaar commented 1 month ago

Same issue here. Any news or workaround?