search

jfrog / bower-art-resolver

Apache License 2.0
15 stars 17 forks source link

Use _ca_ configurations from bowerrc #12

Closed mithun closed 8 years ago

mithun commented 8 years ago

This fixes #11

Commit c642748 made the assumption that the Artifactory URL must be the first search URL.

In line with the above, this commit makes the assumption that the first search CA is intended for Artifactory.

bower registery-client's search.js [0] currently associates the search URL index with the search CA index.

[0] https://github.com/bower/registry-client/blob/master/lib/search.js#L106

eyalbe4 commented 8 years ago

@mithun - thank you for this! @jblaine and all, does this fix work for you as well? (you can install it directly from github till we have it published).

jgibson commented 8 years ago

Yes, this fixes the issue. Please make a new release that includes this fix.

Note that other resolvers use config.ca.default instead of config.ca.search[0]. Previously config.ca.default's behavior was buggy: bower/config#33. However, that has been fixed with the release of Bower 1.6.8.

So if you ever change the assumption that Artifactory must be the first search URL, then you'll probably want to make a similar change to the source of the certificate settings for the Artifactory.

eyalbe4 commented 8 years ago

2.0.5 has been published. Thanks @mithun and @jblaine.