jfrog / bower-art-resolver

Apache License 2.0
15 stars 17 forks source link

Passing actual bower config object to download function. #3

Closed fh1ch closed 8 years ago

fh1ch commented 8 years ago

Using non-standard bower settings (e.g. SSL & proxy) was working fine for fetching components but was failing during download. This fix used the actual bower settings object and passes it to the download function.

eyalbe4 commented 8 years ago

Thanks for this fix @fh1ch . Can you please sign JFrog's CLA so that we can merge the fix? You can sign through this link: http://www.jfrog.com/confluence/display/OSS/How+to+Contribute

fh1ch commented 8 years ago

Hi @eyalbe4! Sure, I just signed the CLA and received the confirmation. Ready to go :smile:

cwmrowe commented 8 years ago

This fixes issues we've been having, but I'm still getting the old version from NPM. Can you update NPM please :-)

eyalbe4 commented 8 years ago

@cwmrowe, Sure, we'll release it early next week.

eyalbe4 commented 8 years ago

@cwmrowe, this fix is part of 2.0.2 which has just been released.