jfrog / bower-art-resolver

Apache License 2.0
15 stars 17 forks source link

API url validation #4

Closed nicolas-vellon closed 8 years ago

nicolas-vellon commented 8 years ago

Hey guys,

I'm just giving a try to this and found you require the string "artifactory" in the repository url.

Is that really necesary?

I.e.: set a host name for the bower repo like bower.mycompanyrepo.com to point artifactory's API through rewrite rules...

eyalbe4 commented 8 years ago

@nicolas-vellon, we certainly wouldn't want to require having the string "artifactory" as part of the URL. If this is indeed the case, this is something we'd like to fix. We will check this. Thank you for reporting this.

eyalbe4 commented 8 years ago

This issue will be fixed as part of the next release.

nicolas-vellon commented 8 years ago

+1

eyalbe4 commented 8 years ago

@nicolas-vellon, version 2.0.2 with this fix has been published.

eyalbe4 commented 8 years ago

@mithun, @rschick, We committed the change. Before publishing this change, can you please try it out by installing it as follows? npm install -g https://github.com/JFrogDev/bower-art-resolver.git

With this change, you can configure the Artifactory URL in two ways:

{   
    "registry": "http://localhost:8080/artifactory/api/bower/bower-virtual",
    "resolvers": [
      "bower-art-resolver"
    ]
}

or if you wish to use different URLs for resolution from Artifactory and for registering packages:

{
    "registry": {
      "register": "https://bower.herokuapp.com",
      "search": [
        "http://localhost:8080/artifactory/api/bower/bower-virtual",
        "https://bower.herokuapp.com"
      ]
    },
    "resolvers": [
      "bower-art-resolver"
    ]
}
mithun commented 8 years ago

i ran a quick test. A bower info and bower install works fine

rschick commented 8 years ago

Works great, thanks @eyalbe4

eyalbe4 commented 8 years ago

Thank you @mithun and @rschick ! New version is published.