jfrog / build-info-go

build-info-go is a Go library and a CLI, which allows generating build-info for a source code project.
https://www.buildinfo.org
Apache License 2.0
64 stars 37 forks source link

Fix #113: Refactor getSitePackagesPath to use python discovery #114

Closed rvodden closed 1 year ago

rvodden commented 1 year ago
github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

rvodden commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

talarian1 commented 1 year ago

Hi @rvodden, thanks a lot for your contribution. I suggest we will wait with those changes, as for Poetry 1.2 and above the file 'direct_url.json' is not created anymore. You can see this discussion for more details. The only usage for the getSitePackagesPath logic is getting those files. Sorry for the inconvenience and thanks again!

rvodden commented 1 year ago

Hi @rvodden, thanks a lot for your contribution. I suggest we will wait with those changes, as for Poetry 1.2 and above the file 'direct_url.json' is not created anymore. You can see this discussion for more details. The only usage for the getSitePackagesPath logic is getting those files. Sorry for the inconvenience and thanks again!

aha great! I must admit i was thinking of authoring a poetry plugin which would output buildinfo... would that be interesting as an alternative to having to install jf-cli ?

talarian1 commented 1 year ago

Thanks again for your interest in this, and for your effort. I'm closing this for now, as we discussed here we will need a new implementation to solve this issue.