search

jfrog / build-info-go

build-info-go is a Go library and a CLI, which allows generating build-info for a source code project.
https://www.buildinfo.org
Apache License 2.0
61 stars 34 forks source link

fix: adds support for all yarn version by removing the minimun versio… #183

Closed grinish21 closed 10 months ago

grinish21 commented 10 months ago

…n check.

PR #172 adds supports for yarn V1 but fails to actually enable it when building via the API's

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

eranturgeman commented 10 months ago

Thank you @grinish21 for your contribution for our code! Supporting in Yarn V1 is on our track, but it will take some time to fully support all the functionalities we have for Yarn V2. Our recent additions added support in Jfrog CLI command and for creating fixes using Frogbot The block you requested to remove is there for a reason, since we are not supporting buildInfo with Yarn 1 currently. We keep adding more and more support for Yarn V1, as long with support to other package managers so stay tuned for further improvements

grinish21 commented 10 months ago

Thank you @grinish21 for your contribution for our code! Supporting in Yarn V1 is on our track, but it will take some time to fully support all the functionalities we have for Yarn V2. Our recent additions added support in Jfrog CLI command and for creating fixes using Frogbot The block you requested to remove is there for a reason, since we are not supporting buildInfo with Yarn 1 currently. We keep adding more and more support for Yarn V1, as long with support to other package managers so stay tuned for further improvements

Thank you @eranturgeman . been waiting for the Yarn V1 support for a while So was excited to see the PR and use the latest version and i realized that check on min version is stopping it. But either ways I will be keeping an eye for yarn V1 support is there an issue or feature we can monitor for completion.

grinish21 commented 10 months ago

since the yarnV1 support is still in progress closing the PR as this is not needed at the moment.