Type in warning message 'node_models'? - Githubissues

jfrog / build-info-go

build-info-go is a Go library and a CLI, which allows generating build-info for a source code project.

https://www.buildinfo.org

Apache License 2.0

61 stars 34 forks source link

Type in warning message 'node_models'? #202

Closed flcdrg closed 8 months ago

flcdrg commented 8 months ago

Describe the bug

In https://github.com/jfrog/build-info-go/blob/724a12dc781f24eddbc1547f1fe96509876c0b76/build/utils/npm.go#L78 a mention is made to "node_models". I've never heard of this, but I have heard of "node_modules". I wonder if this is a typo and it should say "node_modules"?

             log.Warn("The following dependencies will not be included in the build-info, because they are missing in the npm cache: '" + strings.Join(otherMissingDeps, ",") + "'.\nHint: Try to delete 'node_models' and/or 'package-lock.json'.")

Current behavior

Warning logged "Hint: Try to delete 'node_models' and/or 'package-lock.json'"

Reproduction steps

No response

Expected behavior

No response

Operating system type and version

Linux

Or-Geva commented 8 months ago

Thank you for your contribution, @flcdrg. Your PR has been merged.