search

jfrog / build-info-go

build-info-go is a Go library and a CLI, which allows generating build-info for a source code project.
https://www.buildinfo.org
Apache License 2.0
61 stars 34 forks source link

Doubt Concerning the JSON Schema #230

Open carstencodes opened 5 months ago

carstencodes commented 5 months ago

In the JSON schema, in Line 99, the properties object is closed while modules and issues are omitted.

Is this correct?

When use this schema in a code generator, the code is generated without modules and issues types and properties.

If I apply the following patch 

98d97
<     }
209c208,211
<         "required": ["name", "version"],
---
>           "required": [
>             "name",
>             "version"
>           ],
235a238
>               }

then code will generated including modules and issues.

Is this intentional or a bug?

carstencodes commented 5 months ago

Yet another question: Are you sure, that the vcs configuration is correct? The code generators seem to create "object" / "interface" / "Any" (depending on the Programming Language) from it instead of a concrete type ...