search

jfrog / build-info

Artifactory's open integration layer for CI build servers
https://www.buildinfo.org
Apache License 2.0
147 stars 155 forks source link

Remove the need for setting up a dummy repository #715

Closed markrekveld closed 1 year ago

markrekveld commented 1 year ago

This PR is the continuation of the original PR https://github.com/jfrog/build-info/pull/683 that was reverted because of authentication issues.

This PR adds setting authentication and proxy details if configured, the one missing bit looking at the provided issues in comment https://github.com/jfrog/build-info/pull/683#issuecomment-1451437279

Background info:

The dummy repository is added to allow for the resolution of depedencies using the jfrog cli resolver configuration for Maven. Some maven build plugins, like the org.codehaus.mojo:versions-maven-plugin will try to resolve artifacts using this dummy repository but will always fail.

This PR implements a solution that allows maven build plugins to resolve artifacts using the jfrog cli resolver configuration by configuring the snapshot and release resolver repositories just like the ArtifactoryEclipseResolversHelper and ArtifactorySonatypeResolversHelper do. Instead of configuring a dummy and "hoping" it gets proxied to resolver repositories.

markrekveld commented 1 year ago

@omerzi I updated the dummy removal PR to also include authentication and proxy settings. Can you give it a review?