search

jfrog / build-info

Artifactory's open integration layer for CI build servers
https://www.buildinfo.org
Apache License 2.0
145 stars 154 forks source link

Correct .npmrc for newer versions of NPM #787

Open Spaction opened 4 months ago

Spaction commented 4 months ago
github-actions[bot] commented 4 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Spaction commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

Spaction commented 4 months ago

I'm not part of the dev-ops team, but i'll mention to them that this Plug-in is not being as actively developed. As mentioned, the part where this should shine is with running against Node 15 and Node 20, where as before that would have failed.

Spaction commented 3 months ago

@eyalbe4 Any chance you can re-run the checks?

Spaction commented 3 months ago

@eyalbe4 Is there anything else needing to be done for this to be rechecked?

Spaction commented 3 months ago

@yahavi Are you able to re-execute the checks?

Spaction commented 2 months ago

@RobiNino @eyalbe4 Any change this can have the test re-run?

RobiNino commented 2 months ago

@Spaction , Sorry for the delay, we'll review this soon

RobiNino commented 2 months ago

Hi @Spaction , I took the liberty to update the PR with a few fixes to the tests infrastructure. I also temporarily changed the target branch so that the changes to the workflow made in this PR will reflect in the tests.

Seems like the npm tests are failing. Could you please look into it before we proceed? Thanks

Spaction commented 1 month ago

@RobiNino,

Updated the Unit tests. Can honestly say the test doesn't differ between between the NPMExtractor Test vs the one for NpmBuildInfo. The expanded test for the v15 vs v20 is what would have failed previously during the NPMExtractorTest. Only way to confirm this would be to expand only the unit test to include Node v20 and see that it fails for that branch. This is only to say that the new test can be excluded as the other indirectly tests the method\execution path in its npmCiTest

Spaction commented 1 week ago

@RobiNino Any updates on my last response?

Spaction commented 3 days ago

@RobiNino , @eyalbe4 Any update?